Open
Conversation
Contributor
Can you please let us know actual requirement/issue so that, We will try to support. |
bellekal
reviewed
Oct 10, 2025
|
|
||
| template <typename T> | ||
| ze_result_t FsAccessInterface::readValue(const std::string file, T &val) { | ||
| auto lock = this->obtainMutex(); |
Contributor
There was a problem hiding this comment.
Intention of having lock here is not for handling race conditions for sysfs file reads, But to ensure correct operations with FdCacheInterface (Which ensures quicker reads by avoiding redundant file open and file close operations when multiple reads are requested). Adding lock here ensures fd is not closed before read is completed in multi thread environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the lock used in
SysFsAccessInterface. The lock is not necessary and should be avoided based on below facts:The implementation of this function should be lock-free..