Dml 1.2 compatibility templates - inquiry#446
Merged
Conversation
Contributor
|
DML Verification : 7: ❌ failure |
Contributor
|
PR Verification: ❌ failure |
Contributor
|
DML Verification : 6: ❌ failure |
Contributor
|
DML Verification : 7: ❌ failure |
Contributor
|
DML Verification : 7: ❌ failure |
Contributor
|
DML Verification : 6: ❌ failure |
Contributor
|
PR Verification: ❌ failure |
Contributor
|
DML Verification : 7: ❌ failure |
Contributor
|
DML Verification : 7: ❌ failure |
Contributor
|
PR Verification: ✅ success |
mandolaerik
reviewed
May 26, 2026
| // Test that inquiry accesses bypass dml12_compat_read_register and | ||
| // dml12_compat_write_register (r6 inverts bits in read_register/ | ||
| // write_register; inquiry should access storage directly) | ||
| local uint32 inq_val; |
Contributor
There was a problem hiding this comment.
use uint32_le_t or uint32_be_t if you want a specific endianness. Casting uint32 to uint8* adds an unnecessary risk for undefined behaviour in C; with endian ints there is no such risk.
mandolaerik
requested changes
May 26, 2026
Contributor
mandolaerik
left a comment
mandolaerik
left a comment
There was a problem hiding this comment.
Approved modulo C pedantry nitpick
Contributor
|
PR Verification: ✅ success |
Contributor
|
PR Verification: ✅ success |
mandolaerik
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.2 read_access(write_access) has conditional logic based on
inquiry1.4 calls either get() or read() (set()/write()) in io_memory based on
inquirycompatibility templates ignored that