[SYCL] Remove sycl_ext_oneapi_default_context in preview-breaking mode - #22769
Open
softwaresat wants to merge 4 commits into
Open
[SYCL] Remove sycl_ext_oneapi_default_context in preview-breaking mode#22769softwaresat wants to merge 4 commits into
softwaresat wants to merge 4 commits into
Conversation
Robertkq
approved these changes
Jul 26, 2026
Robertkq
left a comment
Robertkq
left a comment
Contributor
There was a problem hiding this comment.
LGTM, good work!
Only note: In this repository, the body of the PR usually becomes the commit message of the Squash & Merge procedure when the PR is eventually merged, as such I think you should try to keep the body of the PR as concise as possible on the changes made and to add comments to the PR for explaining the decisions behind them
gmlueck
approved these changes
Jul 29, 2026
softwaresat
force-pushed
the
remove-oneapi-default-context
branch
from
July 29, 2026 23:18
177ca06 to
f11e796
Compare
KornevNikita
approved these changes
Jul 30, 2026
Contributor
|
@KseniyaTikhomirova could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
sycl_ext_oneapi_default_contextin preview-breaking mode.platform::ext_oneapi_get_default_context()andSYCL_EXT_ONEAPI_DEFAULT_CONTEXTwith__INTEL_PREVIEW_BREAKING_CHANGES.platform::khr_get_default_context()and the supporteddevice::ext_oneapi_get_default_context()API.removed/when the API is removed from normal builds.
Addresses the
sycl_ext_oneapi_default_contextportion of #22581.