Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

@clero
Copy link
Contributor

@clero clero commented Mar 3, 2015

Domains are browsed twice when applying configurations.
The first one gather syncer of domains which are not
"sequence aware" and launch a sync on them.
The second one launch an apply without providing a syncer set.
It lets sequence aware domains to synchronize if needed.

This patch allows to browse domains only once. If a domain
is sequence aware, it will be synchronized during configurations
restauration. If not, the synchronisation will be delayed at
the end of all applies.

Sequence aware domains are now synchronized first.

Signed-off-by: Jules Clero [email protected]

  

@clero clero force-pushed the sequence_aware_sync branch 2 times, most recently from 0cec4dc to c64ab9d Compare March 5, 2015 17:06
@clero
Copy link
Contributor Author

clero commented Mar 5, 2015

👍 @krocard @dawagner @benaware

clero added 2 commits March 9, 2015 17:25
Domains are browsed twice when applying configurations.
The first one gather syncer of domains which are not
"sequence aware" and launch a sync on them.
The second one launch an apply without providing a syncer set.
It lets sequence aware domains to synchronize if needed.

This patch allows to browse domains only once. If a domain
is sequence aware, it will be synchronized during configurations
restauration. If not, the synchronisation will be delayed at
the end of all applies.

Sequence aware domains are now synchronized first.

Signed-off-by: Jules Clero <[email protected]>
_pLastAppliedConfiguration != NULL is tested twice as we know
that pApplicableDomainConfiguration is not null.
This patch avoids this double test and merge the two conditions.

Signed-off-by: Jules Clero <[email protected]>
@clero clero force-pushed the sequence_aware_sync branch from c64ab9d to ac259c3 Compare March 9, 2015 16:27
@krocard
Copy link
Contributor

krocard commented Mar 17, 2015

👍

@benaware
Copy link
Contributor

👎 Synchronization of all sequence unaware domains needs to say coalesced. This is because the synchronization of sequence aware domains is susceptible to do some read/modify/write operations on syncers which are shared with sequence unaware ones. By synchronizing sequcence unware ones first, we ensure a proper initialization of the shared syncers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants