feat: atomically deposit vault collateral in lending market #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How is this supposed to work on the client side? The client should automatically pick up the new vault, but the bitcoin will stay in the old wallet, so there has to be some kind of migration there as well |
Member
Author
|
Good point @sander2, let's continue the discussion here interlay/interbtc-clients#484 |
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
feat/relock-collateral
branch
from
1a75365 to
e979deb
Compare
sander2
reviewed
Sep 5, 2023
Member
sander2
left a comment
sander2
left a comment
There was a problem hiding this comment.
Nice and clean PR, but I'd like to see a little bit more thorough testing. Specifically, it'd be good to verify the state changes made by the extrinsic
| /// Preconditions: | ||
| /// - the Vault is not liquidated | ||
| /// - the Vault does not have `to_be_issued` or `to_be_redeemed` tokens | ||
| /// - a market exists for the underlying currency |
Member
There was a problem hiding this comment.
- there is enough collateral s.t. the qtoken vault is above the secure threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1072