perf(analytics): skip validateStruct in release mode#8716
perf(analytics): skip validateStruct in release mode#8716mikehardy merged 3 commits intoinvertase:mainfrom
Conversation
Skip superstruct create in production to improve performance.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
@mikehardy Would you mind having a look |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
This is still open because I do like the idea, apologies I haven't been decisive about getting it yet |
mikehardy
added
Workflow: Needs Review
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
I can't think of how the errors thrown in prod would be recoverable anyway so I think this is likely fine. I proposed a small suggestion which I will apply, for lint
|
@mikehardy is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
mikehardy
changed the title
mikehardy
added
Workflow: Pending Merge
2 participants
Description
Skip superstruct create in production to improve performance.
Related issues
#8638