Skip to content

fix(messaging): isSupported make boolean a promise#8798

Merged
mikehardy merged 1 commit intomainfrom
isSupported-type-fix
Dec 9, 2025
Merged

fix(messaging): isSupported make boolean a promise#8798
mikehardy merged 1 commit intomainfrom
isSupported-type-fix

Conversation

@MichaelVerdon
Copy link
Copy Markdown
Contributor

@MichaelVerdon MichaelVerdon commented Dec 9, 2025

Description

In namespace API, we already define it as a promise.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@MichaelVerdon MichaelVerdon marked this pull request as ready for review December 9, 2025 12:36
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Dec 9, 2025 0:39am

Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mikehardy mikehardy merged commit 4d54636 into main Dec 9, 2025
23 of 24 checks passed
@mikehardy mikehardy deleted the isSupported-type-fix branch December 9, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛] Wrong type for isSupported in modular messaging types

3 participants