Skip to content

refactor(app-check)!: match AppCheck type with firebase-js-sdk#8889

Open
russellwheatley wants to merge 20 commits intomainfrom
app-check-match-js-sdk
Open

refactor(app-check)!: match AppCheck type with firebase-js-sdk#8889
russellwheatley wants to merge 20 commits intomainfrom
app-check-match-js-sdk

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley commented Feb 16, 2026

Description

Updates to match firebase-js-sdk:

  • breaking modular AppCheck now matches firebase-js-sdk (no instance methods); use modular functions like initializeAppCheck, getToken, getLimitedUseToken, setTokenAutoRefreshEnabled, onTokenChanged instead, matching firebase-js-sdk. See commit 423b3e915.
  • breaking modular onTokenChanged callback result type changed from AppCheckListenerResult to AppCheckTokenResult. See commit 86982934a.
  • breaking FirebaseApp is no longer exported from @react-native-firebase/app-check; import FirebaseApp from @react-native-firebase/app. See commit 423b3e915.
  • breaking modular type exports no longer include the old statics-based surface (e.g. AppCheckStatics), aligning closer to firebase-js-sdk. See commit f5de6b89b.
  • breaking FirebaseAppCheckTypes is now a type-only export (no runtime export); update any value imports to import type. See commit 540ee789f.
  • Fix AI package required a tweak so app check type still showed as having getToken() method. See commit.
  • chore provider classes were moved into lib/providers.ts (exports updated). See commit 76ab3a848.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-firebase Ready Ready Preview, Comment Feb 16, 2026 5:47pm

Request Review

@russellwheatley russellwheatley changed the title refactor: match AppCheck with firebase-js-sdk refactor(app-check)!: match AppCheck types with firebase-js-sdk Feb 16, 2026
@russellwheatley russellwheatley changed the title refactor(app-check)!: match AppCheck types with firebase-js-sdk refactor(app-check)!: match AppCheck type with firebase-js-sdk Feb 16, 2026
@russellwheatley russellwheatley marked this pull request as ready for review February 16, 2026 19:50
Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - but the docs (migrating to v24 + AppCheck docs with our custom provider config info example etc) definitely need an update for this one or the support load in the area will stay high vs immediately going to zero

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

Hello 👋, this PR has been opened for more than 14 days with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 7 days until this gets closed automatically

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.22%. Comparing base (96fad37) to head (540ee78).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8889      +/-   ##
==========================================
- Coverage   74.84%   71.22%   -3.62%     
==========================================
  Files         213      264      +51     
  Lines        8966    13521    +4555     
  Branches     2081     3396    +1315     
==========================================
+ Hits         6710     9629    +2919     
- Misses       2185     3814    +1629     
- Partials       71       78       +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants