#2582 Correct thread warden so it can cope with multiple threaded JME apps #2583
+155
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JME roots on multiple threads
richardTingle
commented
Jan 21, 2026
| simpleInitApp(); | ||
| } | ||
|
|
||
| @Override |
Member
Author
There was a problem hiding this comment.
I removed this because the restriction is held in a WeakHashMap so the old restrictions will age out anyway and trying to do a per thread removal of the entire scene graph would be unnecessarily slow and almost certainly pointless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the thread warden to permit multiple threads each with their own root node (on different threads). Those restrictions are then separately tracked such that each scene graph is modifiable only on its own thread