Skip to content

Conversation

@jacwu
Copy link
Owner

@jacwu jacwu commented Sep 26, 2025

  • Create a new GitHub Actions workflow for PR Copilot Review.
  • Implement steps to compute diffs, prepare fallback reviews, and run the Copilot CLI for code reviews.
  • Update the normalization script to read from the new raw review output file instead of the previous codex review file.

- Create a new GitHub Actions workflow for PR Copilot Review.
- Implement steps to compute diffs, prepare fallback reviews, and run the Copilot CLI for code reviews.
- Update the normalization script to read from the new raw review output file instead of the previous codex review file.
@github-actions
Copy link

File Concern Recommendation Severity
.github/workflows/pr-codex-review.yml Extra blank line at L7 Remove the unnecessary blank line after the on: section for consistency minor
.github/workflows/pr-codex-review.yml Trailing whitespace at L105 Remove trailing whitespace after the if condition minor
.github/workflows/pr-codex-review.yml Environment variable moved to job level but still referenced in steps The AZURE_OPENAI_BASE_URL environment variable was removed from individual steps but is still used in the Codex CLI installation step major
.github/workflows/pr-copilot-review.yml Extra blank line at L6 Remove the unnecessary blank line after the on: section for consistency minor
.github/workflows/pr-copilot-review.yml Trailing whitespace at L94 Remove trailing whitespace after the if condition minor
.github/workflows/pr-copilot-review.yml Missing error handling for Copilot CLI installation No validation that the Copilot CLI installation was successful before attempting to use it major
.github/workflows/pr-copilot-review.yml Inconsistent indentation for GITHUB_TOKEN environment variable at L57 Use consistent 2-space indentation instead of 4 spaces minor
scripts/normalize_review_result.py Hardcoded filename references updated but error message could be more generic Consider using a more generic error message that doesn't reference specific filenames info

Reviewed by GitHub Copilot CLI

@github-actions
Copy link

File Concern Recommendation Severity
.github/workflows/pr-copilot-review.yml:L84 The new Copilot review step pipes the CLI through tee without set -o pipefail, so the step will report success even if copilot exits non-zero, silently skipping the review. Either enable set -o pipefail before running the pipeline or capture ${PIPESTATUS[0]} after the command so the step fails when copilot does. major

Reviewed by Codex

@jacwu jacwu merged commit b5eaf37 into testbranch Sep 26, 2025
11 checks passed
@jacwu jacwu requested a review from Copilot October 9, 2025 10:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow for Copilot-based PR reviews and standardizes output handling between the existing Codex and new Copilot workflows.

  • Add new GitHub Actions workflow for PR Copilot Review that parallels the existing Codex review functionality
  • Normalize file naming conventions by using raw_review.md as the standard intermediate output file across both workflows
  • Update the normalization script to read from the standardized filename

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr-copilot-review.yml New workflow implementing Copilot CLI-based code reviews with similar structure to existing Codex workflow
.github/workflows/pr-codex-review.yml Updated to use standardized raw_review.md filename and improved environment variable handling
scripts/normalize_review_result.py Updated to read from raw_review.md instead of codex_review.md for consistency

Comment on lines +57 to +58
env:
GITHUB_TOKEN: ${{ secrets.COPILOT_CLI_PAT }}
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation - the environment variable should be indented with 2 spaces to align with the step structure, not 4 spaces.

Copilot uses AI. Check for mistakes.

- name: Run Copilot code review
env:
GITHUB_TOKEN: ${{ secrets.COPILOT_CLI_PAT }}
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation - the environment variable should be indented with 2 spaces to align with the step structure, not 4 spaces.

Suggested change
GITHUB_TOKEN: ${{ secrets.COPILOT_CLI_PAT }}
GITHUB_TOKEN: ${{ secrets.COPILOT_CLI_PAT }}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants