Don't crop non-squared icons #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
interesting use case.. thanks for the PR! 😁🙌 |
jahirfiquitiva
approved these changes
Aug 20, 2025
Owner
|
@spocky did you test the icon dialog? |
Aleksanrd140792
approved these changes
Nov 28, 2025
Aleksanrd140792
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using non 1:1 icons, the current layout is hard to read as they overlay each-other because of the
centerCrop.Changing to
fitCenterfixes it, as shown in the screenshots below.Note that for 1:1 icons exchanging centerCrop for fitCenter shouldn't make any difference, so the only icons that will be impacted as those non 1:1.
Motivation
Projectivy Launcher is a Launcher for Android Tv. It can use 1:1 icons as well as 16:9 icons.
It recently got its first Icon Pack, however, the picker is currently not easy to read because of this issue.