Ensure consistent pit cells ordering before breaching #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #418
Make sure that each run of the tool gives the same output. This is needed because the stack is built using parallel processing meaning that the values aren't always in the same order. This isn't an issue as long as their is no height ties... which happen quite often. Sorting first by X and Y ensure consistent ordering as this XY tuple is unique for each cell.
My PR use three consecutive
sort_by()but I'm sure there is an more elegant or concise way to do it. An alternative might be to build the stack while keeping track of each row.