Decrement refcount for encoded set items#991
Merged
jcrist merged 3 commits intojcrist:mainfrom Apr 8, 2026
Merged
Conversation
Collaborator
|
Ported to the community fork msgspec-arise: PR #29 |
Owner
|
Thanks, this is in! I pushed a few extra fixups, but this was mostly good-to-go. I plan to merge a few other PRs before cutting a release today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a reference leak in the set encoders used by both JSON and MessagePack.
json_encode_setandmpack_encode_setiterate withPyIter_Next, which returns a new reference for each item. Those item references were not decref'd after successful encoding, so set elements could be kept alive longer than intended.Changes
Py_DECREF(item)injson_encode_setPy_DECREF(item)inmpack_encode_setmsgspec.jsonandmsgspec.msgpackTesting
Notes
This script reproduces the bug. Repeatedly encoding sets causes the memory to quickly climb to several GB.