refactor: optimize beam search sequence reuse.#1223
Merged
RobbieLeung merged 1 commit intojd-opensource:mainfrom Apr 10, 2026
Merged
refactor: optimize beam search sequence reuse.#1223RobbieLeung merged 1 commit intojd-opensource:mainfrom
RobbieLeung merged 1 commit intojd-opensource:mainfrom
Conversation
Collaborator
RobbieLeung
commented
Apr 8, 2026
RobbieLeung
commented
- snapshot generated suffix state for beam candidates instead of copying full sequences
- reuse or replace sequence objects based on suffix shape before applying beam results
- keep batch beam-search output updates aligned with source sequence state
- snapshot generated suffix state for beam candidates instead of copying full sequences - reuse or replace sequence objects based on suffix shape before applying beam results - keep batch beam-search output updates aligned with source sequence state
RobbieLeung
requested review from
DongheJin,
JimHsiung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the beam search implementation by introducing the BeamSourceInfo structure and updating BeamCandidate to optimize sequence management and token updates. The changes improve efficiency by avoiding unnecessary sequence re-allocations and refining the logic for updating generated tokens. Feedback focuses on ensuring that all new member variables in the BeamSourceInfo and BeamCandidate structures follow the repository's naming convention (Rule 16), which requires a trailing underscore for member variables.
XuZhang99
approved these changes
Apr 9, 2026
LMX-xin
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.