wip: implement Network Segment Range resource #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an implementation to manage Network Segment Ranges which is a Neutron extension. This depends on gophercloud/gophercloud#3614. For now it pulls that in with a replacement in go.mod.
mandre
reviewed
Jan 28, 2026
Collaborator
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR. I notice you've chosen the hard way decided to write the controller entirely by hand?
I strongly recommend you follow the docs at https://k-orc.cloud/development/overview/ and use the scaffolding tool. This ensures the code and the testing is consistent with the rest of the project. It will also make your life soooo much easier.
We'll also need e2e tests. We can't merge code unless it's properly tested in CI. You'll need to configure the devstack environment to have the necessary extension (similar to what we do in gophercloud).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation to manage Network Segment Ranges which is a Neutron extension.
This depends on gophercloud/gophercloud#3614. For now it pulls that in with a replacement in go.mod.