Enhancement: Add drift detection and automatic reconciliation#668
Merged
mandre merged 1 commit intok-orc:mainfrom Apr 14, 2026
Merged
Enhancement: Add drift detection and automatic reconciliation#668mandre merged 1 commit intok-orc:mainfrom
mandre merged 1 commit intok-orc:mainfrom
Conversation
This was referenced Feb 4, 2026
Open
mandre
reviewed
Feb 16, 2026
Collaborator
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
What part of the code needs changing? I expect we detail how shouldReconcile changes.
eshulman2
force-pushed
the
drift-d-proposal
branch
from
3134799 to
a9f9abf
Compare
mandre
reviewed
Mar 11, 2026
eshulman2
force-pushed
the
drift-d-proposal
branch
from
a9f9abf to
eda8a6f
Compare
mandre
reviewed
Mar 12, 2026
eshulman2
force-pushed
the
drift-d-proposal
branch
from
eda8a6f to
c610a4f
Compare
mandre
reviewed
Mar 19, 2026
eshulman2
force-pushed
the
drift-d-proposal
branch
from
c610a4f to
0fa5f18
Compare
eshulman2
force-pushed
the
drift-d-proposal
branch
from
0fa5f18 to
ab42db9
Compare
mdbooth
reviewed
Mar 19, 2026
Contributor
mdbooth
left a comment
mdbooth
left a comment
There was a problem hiding this comment.
A few comments, but looks very reasonable to me.
Contributor
Author
|
@mdbooth thanks for the review, I addressed all comments in the review and re-opened relevant threads for you to comment about in case you want to continue the discussions there. |
mandre
reviewed
Apr 13, 2026
Proposal for drift detection feature.
eshulman2
force-pushed
the
drift-d-proposal
branch
from
ab42db9 to
7d548af
Compare
mandre
approved these changes
Apr 14, 2026
Collaborator
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Congrats on the first enhancement proposal 🎉
Contributor
|
Congrats @eshulman2! Good enhancement to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for drift detection feature.