Dockerizing Dev Setup #175
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
k3rnelpan1c-dev
left a comment
k3rnelpan1c-dev
left a comment
There was a problem hiding this comment.
I am not too familiar with Makefile syntax, yet looks reasonable enought
| env_file: | ||
| - .env.development | ||
| environment: | ||
| - SSH_AUTH_SOCK=${SSH_AUTH_SOCK} |
Contributor
There was a problem hiding this comment.
could you elaborate what this does? (not familiar with this EnvVar)
| @@ -0,0 +1,2 @@ | |||
| GITHUB_TOKEN=<create-your-own-token> | |||
| GITHUB_REPOSITORY=sushie1984/pr-update-extended | |||
Contributor
There was a problem hiding this comment.
Just making a note here so we don't forget about it
| @@ -0,0 +1,23 @@ | |||
| FROM alpine:3.16.2 AS base | |||
Contributor
There was a problem hiding this comment.
any reason not to use the official Node image in alpine flavour?
Comment on lines
+5
to
+7
| WORKDIR /home/node/ | ||
|
|
||
| COPY package.json package-lock-json* ./ |
Contributor
There was a problem hiding this comment.
is there a benefit in first setting the work dir instead of directly copying in the file to the required location?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
dockerizedsetup for easier development on local machineChange(s)