fix: changes on queryIncosistencyValidator in HardwareDetails to avoid refetch loop#1708
Conversation
…s to avoid refetch loop
MarceloRobert
left a comment
There was a problem hiding this comment.
Looks good, but it seems like it's still duplicating some requests. On the local db, it duplicates if I access hardwareDetails through the new listing, and on the production db, it duplicates when I change the commit of a tree via the selector of the treeTable (usually happens on mainline tree that has more data), but it's not in every hardware
It seems just |
Have you tested to check if it really isn't related to |
yeah, I have tested it, |
Ok then. Can you create an issue for that? We always need to have issues to track what needs to be done and when a problem has been seen. nit: in this case in your phrase you should use 'still' instead of 'yet', I've noticed it other times too 😬 |
MarceloRobert
left a comment
There was a problem hiding this comment.
LGTM, fixes a piece of this problem puzzle
Description
This PR changes useQueryInconsistencyInvalidator in HardwareDetails that could re-trigger continuously due to unstable navigateParams and expected count mismatches during tree/commit filtering, causing repeated invalidations/requests.
Closes #1710