pubsub: Remove cloudevents dependency#707
Merged
Merged
Conversation
The pinned cloudevents 2.0.0 no longer provides the cloudevents.http module, so api/pubsub.py and api/pubsub_mongo.py fail to import and the API cannot start. Instead of migrating to the new cloudevents v2 API, drop the library: it was only used to fill in the "id", "time" and "specversion" attributes and serialize the event to JSON. Add a small to_cloudevent_json() helper that emits the exact same CloudEvents 1.0 JSON envelope (verified byte-identical against cloudevents 1.12.1 output for dict data, string data and extension attributes such as "owner"), so the wire format consumed by external subscribers is unchanged. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned cloudevents 2.0.0 no longer provides the cloudevents.http module, so api/pubsub.py and api/pubsub_mongo.py fail to import and the API cannot start. Instead of migrating to the new cloudevents v2 API, drop the library: it was only used to fill in the "id", "time" and "specversion" attributes and serialize the event to JSON.
Add a small to_cloudevent_json() helper that emits the exact same CloudEvents 1.0 JSON envelope (verified byte-identical against cloudevents 1.12.1 output for dict data, string data and extension attributes such as "owner"), so the wire format consumed by external subscribers is unchanged.