Skip to content

Document VETH pair limitation with containers#1376

Merged
troglobit merged 2 commits intomainfrom
copilot/review-issue-947
Feb 6, 2026
Merged

Document VETH pair limitation with containers#1376
troglobit merged 2 commits intomainfrom
copilot/review-issue-947

Conversation

Copy link

Copilot AI commented Jan 29, 2026

Description

Current implementation requires at least one side of every VETH pair to remain in the host namespace. Both ends cannot be assigned to different containers (confd skips setup for container interfaces; if both skip, the pair is never created).

Added limitation notes to:

  • container.md: IMPORTANT callout in "Container Host Interface" section before VETH examples
  • infix-if-veth.yang: Module-level description
  • infix-if-container.yang: host identity description

The actual fix to support inter-container VETH pairs is tracked in #941.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Assess and propose a solution for issue #947 Document VETH pair limitation with containers Jan 29, 2026
Copilot AI requested a review from troglobit January 29, 2026 20:02
@troglobit troglobit requested review from jovatn and removed request for troglobit January 29, 2026 20:05
@troglobit troglobit linked an issue Jan 29, 2026 that may be closed by this pull request
@troglobit troglobit marked this pull request as ready for review January 29, 2026 20:08
@troglobit troglobit removed their assignment Jan 29, 2026
@troglobit troglobit added this to the Infix v26.02 milestone Feb 2, 2026
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What's going on with that empty "Initial plan" commit though?

@troglobit
Copy link
Contributor

Looks good. What's going on with that empty "Initial plan" commit though?

Yeah, sorry about that, it's Copilot. It creates an empty commit I guess to hook into from the agent. I've been manually squashing these for the other branches.

@troglobit troglobit moved this to Blocked in Infix & C:o Feb 4, 2026
@troglobit troglobit self-assigned this Feb 4, 2026
troglobit and others added 2 commits February 6, 2026 15:56
Add documentation noting that at least one side of a VETH pair must
remain in the host namespace. Both ends cannot be assigned to different
containers.

Updates:
- container.md: Added IMPORTANT note in Container Host Interface section
- infix-if-veth.yang: Added note in module description
- infix-if-container.yang: Added note in host identity description

Fixes: #947
Related: #941

Co-authored-by: troglobit <183517+troglobit@users.noreply.github.com>
[skip ci]

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit force-pushed the copilot/review-issue-947 branch from 915a539 to 91374a1 Compare February 6, 2026 14:57
@troglobit troglobit merged commit 7bcbd3c into main Feb 6, 2026
@troglobit troglobit deleted the copilot/review-issue-947 branch February 6, 2026 14:58
@github-project-automation github-project-automation bot moved this from Blocked to Done in Infix & C:o Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Document limitation using veth pairs between containers

3 participants