-
Notifications
You must be signed in to change notification settings - Fork 15
Keystore refactor and documentation #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
13
commits into
main
Choose a base branch
from
copilot/add-infix-keystore-documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+977
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Add documentation for Infix keystore usage
Add keystore documentation
Jan 29, 2026
mattiaswal
reviewed
Jan 29, 2026
d74a6bb to
f44dd91
Compare
[skip ci] Fixes #914 Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
35749cd to
4e71656
Compare
c00ec33 to
e337ad0
Compare
Signed-off-by: Joachim Wiberg <[email protected]>
Infix key format identities now derive from the IETF bases, so the standard identityref accepts them without any need for deviations. This also preserves the nacm default rules, which were inadvertently dropped before. Also rename format identities for generality: - wifi-preshared-key-format -> renamed: 'passphrase-key-format' - wireguard-symmetric-key-format -> use IETF 'octet-string-key-format' Since cleartext-symmetric-key is now type binary (base64-encoded), the WiFi backends (station and AP) decode values before passing them to wpa_supplicant and hostapd. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
This update brings new support for editing cleartext-symmetric-keys with the 'change' command. The cleartext-symmetric-key is of type binary and its use differs between different key-formats. Signed-off-by: Joachim Wiberg <[email protected]>
Helper command to improve the UX for setting up Wireguard tunnels. Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Since the WiFi passphrase is base64 encoded in the keystore configuration it's quite difficult for a human to check what the password is. This commit adds support for showing it in actual cleartext for admin level users from the admin-exec context using 'show interface wifiN' (details view). Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
e337ad0 to
d87ae9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The keystore is referenced in management.md but lacked dedicated user documentation. Users couldn't discover supported key types (RSA, X25519, WiFi PSK, WireGuard PSK) or usage patterns without exploring YANG models.
Also in this PR is a "revert" of the augments and deviations made earlier in this release cycle to ietf-keystore. The changes now amount to adding new identities only, keeping the IETF yang model intact and compatible with other models.
To aid with the UX of working with 'type binary' settings like
cleartext-symmetric-key, the CLI helperchangehas been expanded to allow users to enter a WiFi passphrase without showing anyone peeking over their shoulder.Support for an admin-exec level
wireguard <genkey | genpskcommand has also been added to aid users setting up Wireguard tunnels. Thedoprefix is really useful in such cases.Checklist
Tick relevant boxes, this PR is-a or has-a:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.