Docs/fix subscription todo comments#6546
Merged
knative-prow[bot] merged 4 commits intoknative:mainfrom Jan 12, 2026
Merged
Conversation
- Add example output for 'kn subscription describe' command - Add comprehensive 'Updating a Subscription' section with kn and kubectl examples - Include three practical update scenarios: changing sink, adding dead letter sink, and updating reply sink - Remove TODO comments once addressed Fixes knative/docs issue with incomplete subscription documentation
- Replace 'kn subscription create' with 'kn subscription update' for updating subscriptions - Remove unnecessary --channel parameter from update commands - Fix 'kubectl subscription delete' to 'kubectl delete subscription' - Simplify update command examples based on actual kn CLI behavior Verified with local Knative cluster testing.
Consolidated three separate update examples into one that shows all parameters together. Makes the documentation more concise while still covering all update scenarios.
Reverting kubectl command back to original syntax as requested.
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
knative-prow
bot
added
the
size/M
Contributor
Author
creydr
approved these changes
Jan 12, 2026
Member
creydr
left a comment
creydr
left a comment
There was a problem hiding this comment.
Thanks for working on this @Kunal1522
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, Kunal1522 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve TODO comments in subscriptions.md
Problem
Two TODO comments in subscriptions.md needed resolution:
kn subscription describecommandknCLIChanges
kn subscription describeexample output (lines 144-174)kn subscription updatecommandknandkubectlapproachesRelease Notes