Skip to content

mcp: change DeleteInput.All from *string to *bool#3710

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
Elvand-Lie:fix/mcp-delete-all-bool
May 15, 2026
Merged

mcp: change DeleteInput.All from *string to *bool#3710
knative-prow[bot] merged 2 commits into
knative:mainfrom
Elvand-Lie:fix/mcp-delete-all-bool

Conversation

@Elvand-Lie
Copy link
Copy Markdown
Contributor

@Elvand-Lie Elvand-Lie commented May 12, 2026

The All field in DeleteInput was typed as *string but the underlying func delete --all CLI flag is boolean. This caused the JSON schema to present a string field to MCP clients instead of a boolean, and passed the flag as --all true (two separate args) instead of --all.

Change All to *bool and use appendBoolFlag instead of appendStringFlag.

Changes

  • Change DeleteInput.All from *string to *bool
  • Switch from appendStringFlag to appendBoolFlag for the --all flag

Fixes #3706

Release Note


Docs


The All field in DeleteInput was typed as *string but the underlying func delete --all CLI flag is boolean. This caused the JSON schema to present a string field to MCP clients instead of a boolean, and passed the flag as --all true (two separate args) instead of --all.

Change All to *bool and use appendBoolFlag instead of appendStringFlag.

Signed-off-by: elvandlie@gmail.com <elvandlie@gmail.com>
@knative-prow knative-prow Bot added the kind/bug Bugs label May 12, 2026
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 12, 2026 14:18
@knative-prow knative-prow Bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels May 12, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 12, 2026

Hi @Elvand-Lie. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.90%. Comparing base (2b6fb02) to head (eda7327).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3710      +/-   ##
==========================================
- Coverage   56.91%   56.90%   -0.01%     
==========================================
  Files         181      181              
  Lines       20928    20928              
==========================================
- Hits        11912    11910       -2     
- Misses       7808     7810       +2     
  Partials     1208     1208              
Flag Coverage Δ
e2e 36.15% <0.00%> (-0.01%) ⬇️
e2e go 32.75% <0.00%> (ø)
e2e node 28.48% <0.00%> (ø)
e2e python 33.11% <0.00%> (-0.01%) ⬇️
e2e quarkus 28.62% <0.00%> (ø)
e2e rust 28.03% <0.00%> (ø)
e2e springboot ?
e2e typescript 28.61% <0.00%> (+0.02%) ⬆️
e2e-config-ci 17.88% <0.00%> (ø)
integration 17.44% <0.00%> (+<0.01%) ⬆️
unit macos-14 44.99% <100.00%> (ø)
unit macos-latest 44.99% <100.00%> (ø)
unit ubuntu-24.04-arm 45.16% <100.00%> (ø)
unit ubuntu-latest 45.84% <100.00%> (ø)
unit windows-latest 44.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: elvandlie@gmail.com <elvandlie@gmail.com>
@gauron99
Copy link
Copy Markdown
Contributor

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. lgtm 🤖 PR is ready to be merged. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels May 15, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elvand-Lie, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved 🤖 PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@knative-prow knative-prow Bot merged commit 5c90388 into knative:main May 15, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. kind/bug Bugs lgtm 🤖 PR is ready to be merged. ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcp: DeleteInput.All should be *bool, not *string

2 participants