mcp: change DeleteInput.All from *string to *bool#3710
Conversation
The All field in DeleteInput was typed as *string but the underlying func delete --all CLI flag is boolean. This caused the JSON schema to present a string field to MCP clients instead of a boolean, and passed the flag as --all true (two separate args) instead of --all. Change All to *bool and use appendBoolFlag instead of appendStringFlag. Signed-off-by: elvandlie@gmail.com <elvandlie@gmail.com>
|
Hi @Elvand-Lie. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3710 +/- ##
==========================================
- Coverage 56.91% 56.90% -0.01%
==========================================
Files 181 181
Lines 20928 20928
==========================================
- Hits 11912 11910 -2
- Misses 7808 7810 +2
Partials 1208 1208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: elvandlie@gmail.com <elvandlie@gmail.com>
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elvand-Lie, gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
Allfield inDeleteInputwas typed as*stringbut the underlyingfunc delete --allCLI flag is boolean. This caused the JSON schema to present a string field to MCP clients instead of a boolean, and passed the flag as--all true(two separate args) instead of--all.Change
Allto*booland useappendBoolFlaginstead ofappendStringFlag.Changes
DeleteInput.Allfrom*stringto*boolappendStringFlagtoappendBoolFlagfor the--allflagFixes #3706
Release Note
Docs