Skip to content

fix(mcp): use 'config' prefix for remove help resources#3712

Open
xenonnn4w wants to merge 1 commit into
knative:mainfrom
xenonnn4w:fix/mcp-remove-help-resources
Open

fix(mcp): use 'config' prefix for remove help resources#3712
xenonnn4w wants to merge 1 commit into
knative:mainfrom
xenonnn4w:fix/mcp-remove-help-resources

Conversation

@xenonnn4w
Copy link
Copy Markdown
Contributor

@xenonnn4w xenonnn4w commented May 12, 2026

PR Description

I. Describe what this PR does

  • Fixes Volumes/Labels/Envs Remove Help MCP resources invoking func list <x> remove --help instead of func config <x> remove --help.
  • Corrects generated resource URIs from func://help/list/<x>/remove to func://help/config/<x>/remove, matching each resource's description.

Fix

VI. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xenonnn4w
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 12, 2026 18:52
@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label May 12, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 12, 2026

Hi @xenonnn4w. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label May 12, 2026
@RayyanSeliya
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.84%. Comparing base (5e9d6f8) to head (114198e).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3712      +/-   ##
==========================================
+ Coverage   53.33%   56.84%   +3.50%     
==========================================
  Files         181      180       -1     
  Lines       20671    20922     +251     
==========================================
+ Hits        11025    11893     +868     
+ Misses       8573     7816     -757     
- Partials     1073     1213     +140     
Flag Coverage Δ
e2e 36.14% <0.00%> (-0.16%) ⬇️
e2e go 32.75% <0.00%> (?)
e2e node 28.50% <0.00%> (?)
e2e python 33.11% <0.00%> (?)
e2e quarkus 28.62% <0.00%> (?)
e2e rust 28.02% <0.00%> (?)
e2e springboot 26.52% <0.00%> (?)
e2e typescript 28.61% <0.00%> (?)
e2e-config-ci 17.88% <0.00%> (-0.20%) ⬇️
integration 17.41% <0.00%> (?)
unit macos-14 44.99% <100.00%> (+1.38%) ⬆️
unit macos-latest 44.99% <100.00%> (+1.38%) ⬆️
unit ubuntu-24.04-arm 45.16% <100.00%> (+1.35%) ⬆️
unit ubuntu-latest 45.84% <100.00%> (+1.36%) ⬆️
unit windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants