-
Notifications
You must be signed in to change notification settings - Fork 12
Basic Windows and Linux CI workflows #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
Signed-off-by: Marek Aufart <[email protected]>
|
|
||
| jobs: | ||
| test-suite: | ||
| uses: aufi/kantra-cli-tests/.github/workflows/test-suite.yaml@basic-workflows # Replace with konveyor-ecosystem (cannot do checkout before for different OSs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will replace aufi fork in followup PRs, this is actually faster to execute tests with modified actions, also the workflow would fail immediately on not existing actions since it is not yet merged in main branch.
| git clone https://github.com/ibragins/konveyor-cli-deployment.git | ||
| cd konveyor-cli-deployment | ||
| pip install -r requirements.txt | ||
| echo '{"misc_downstream_path": "","temp_dir": "","extract_binary": "","get_images_output": "","bundle": "","no_brew": "","ssh_user": "","ssh_key": ""}' >> config.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least empty values are needed with current version of konveyor-cli-deployment
|
@abrugaro Ready for your review. The test failures will be addressed in follow-up PRs, main point of this PR is to setup and trigger those workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one consideration
| echo "KANTRA_CLI_PATH=/home/runner/.kantra/kantra" >> .env | ||
| echo "REPORT_OUTPUT_PATH=${{ github.workspace }}/report" >> .env | ||
| echo "PROJECT_PATH=${{ github.workspace }}" >> .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .env file also need to configure the followin properties for analysis test on private repos:
GIT_USERNAMEGIT_PASSWORD
This can be configured in a follow-up PR as the test that you're running right now is not using these properties.
Edit: I see the ci failures, I believe those can be addressed in next prs but we can merge this initial work, wdyt @ibragins ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abrugaro git credentials are required for some tests only, CI purpose is to run BASIC tests, so actually those parameters can stay blanked.
Regarding failures - I would like to solve them before merging if failures are related to the changes that this PR brings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for feedback!
- credentials - correct, should be setup in these workflows once we add an application that needs credentials (so likely in one of following PRs)
- failures - this PR adds github workflows, so those failures doesn't change any existing test. Based on our recent discussion, going to address those failures on a fresh simple analysis test case in TIER0 analysis tests with full results assertion #48 (that most likely will modify test workflows to allow pass the given analysis test case)
Adding basic workflow structure to allow run this repo tests as part of upstream CI.
Work in progress, there are some things to be discussed (primary updates here, kantra-tests structure and in konveyor-cli-deployment tool to fit together even nicely).