🐛 Add api_hub_tests_ref to CI workflow#501
Conversation
Signed-off-by: Dylan Murray <dymurray@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main | ||
| with: | ||
| operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:2h | ||
| api_hub_tests_ref: release-0.8 |
There was a problem hiding this comment.
We probabaly need both (hub and full API tests ref) like https://github.com/konveyor/tackle2-hub/blob/release-0.8/.github/workflows/main.yml#L94-L97
api_hub_tests_ref: "release-0.8"
api_tests_ref: "release-0.8"
Signed-off-by: Dylan Murray <dymurray@redhat.com>
| @@ -54,3 +54,5 @@ jobs: | |||
| uses: konveyor/ci/.github/workflows/global-ci-bundle.yml@main | |||
| with: | |||
| operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:2h | |||
There was a problem hiding this comment.
Looking on test failure with Daytrader, that looks somehow familiar from last weeks, this doesn't setup release-0.8-based Konveyor, at least it is not in the workflow, as a addition to fork branches, we might need specify also https://github.com/konveyor/ci/blob/main/.github/workflows/global-ci-bundle.yml#L16-L25, but maybe I'm wrong, just quickly looked on the failure.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
|
@dymurray did you still want to merge this? It looks like there is a conflict that needs to be resolved. |
No description provided.