Skip to content

Conversation

@jortel
Copy link
Contributor

@jortel jortel commented Nov 21, 2024

Add svn support tags. Need to support 2 use cases:

  1. The user supplies the fully qualified URL including the branch/tag and directory within the repository for the application.
    • branch must be blank.
    • root path must be blank.
  2. The user supplies the URL to the root of the repository. Must not include branch or subdir to the application.
    • branch will be appended to the URL (when specified). Must be fully qualified path as needed. Ex: tags/v1.2. /trunk is no longer assumed.
    • root path will be append to the URL (when specified).

Some minor re-organization. Better practice to have exported (public) methods at the top.

ref: https://issues.redhat.com/browse/MTA-4236

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
github.com/jortel/go-utils v0.1.2
github.com/konveyor/tackle2-hub v0.5.0-rc.1.0.20240726125502-8bb3c0911660
github.com/onsi/gomega v1.27.6
github.com/swaggo/swag v1.16.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint: go mod tidy picked these up for some reason.

HomeDir, _ = os.UserHomeDir()
}

type Remote = api.Repository
Copy link
Contributor Author

@jortel jortel Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint: added for readability.

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Validate() (err error)
Fetch() (err error)
Branch(name string) (err error)
Branch(ref string) (err error)
Copy link
Contributor Author

@jortel jortel Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint: This need to be more flexible. For git, it would be a branch or tag name. For svn, it needs to be a URL.

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel marked this pull request as ready for review November 22, 2024 14:37
@dymurray dymurray added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants