✨ Add app details: Include a list of targets the project was checked against #2140
Conversation
…ainst Signed-off-by: DvoraShechter1 <[email protected]>
DvoraShechter1
requested review from
ibolton336,
rszwajko and
sjd78
as code owners
…ainst Signed-off-by: DvoraShechter1 <[email protected]>
Signed-off-by: sarinailinger <[email protected]>
Signed-off-by: DvoraShechter1 <[email protected]>
Translation support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 39.20% 41.97% +2.77%
==========================================
Files 146 175 +29
Lines 4857 5644 +787
Branches 1164 1343 +179
==========================================
+ Hits 1904 2369 +465
- Misses 2939 3259 +320
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
left a comment
sjd78
left a comment
There was a problem hiding this comment.
All the basics are there. Need to update the render parts a bit.
Does it make more sense to put the Targets on the Reports tab? That is the tab where the results are available to download.
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
…attribute to mapped components and 'Not available' message for empty analysis. Signed-off-by: DvoraShechter1 <[email protected]>
| onEditClick={onEditClick} | ||
| onCloseClick={onCloseClick} | ||
| /> | ||
| <TextContent className={spacing.mtLg}> |
There was a problem hiding this comment.
Since this is talking about the targets for an analysis, this content should be on the Reports tab.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
|
This PR is still relevent |
5 participants
Add iInformation in the app details:
list of targets that the project was checked against
part 1 from #2012