feat: add sandbox_creation_latency_ms metric #125
+143
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for agent-sandbox canceled.
|
barney-s
force-pushed
the
issue-123-fixes
branch
from
af875ee to
95c225a
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
barney-s
force-pushed
the
issue-123-fixes
branch
from
95c225a to
856c74d
Compare
Contributor
Author
|
@vicentefb FYI |
barney-s
force-pushed
the
issue-123-fixes
branch
from
856c74d to
f3de7e0
Compare
k8s-ci-robot
added
size/M
barney-s
force-pushed
the
issue-123-fixes
branch
2 times, most recently
from
d3242c8 to
26710dc
Compare
k8s-ci-robot
added
size/S
barney-s
force-pushed
the
issue-123-fixes
branch
from
26710dc to
e79aaca
Compare
k8s-ci-robot
added
size/L
barney-s
force-pushed
the
issue-123-fixes
branch
4 times, most recently
from
f9268c9 to
856c74d
Compare
barney-s
force-pushed
the
issue-123-fixes
branch
2 times, most recently
from
90c0ee1 to
fc23586
Compare
barney-s
changed the title
sdowell
reviewed
Oct 31, 2025
sdowell
reviewed
Oct 31, 2025
barney-s
force-pushed
the
issue-123-fixes
branch
from
fc23586 to
c2cf5ae
Compare
Adds a new histogram metric to track the time it takes for a sandbox to become ready after it has been created.
barney-s
force-pushed
the
issue-123-fixes
branch
from
c2cf5ae to
a298e7b
Compare
Contributor
|
@barney-s what's the state of this PR? We are really interested in this metric as well! btw I already have some code based on your branch to also track E2E latency for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new histogram metric to track the time it takes for a sandbox to become ready after it has been created.
Fixes #123