Skip to content

Conversation

@mszadkow
Copy link
Contributor

@mszadkow mszadkow commented Dec 3, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move ConfigureClusterProfileCache to config pkg add unit tests.

Which issue(s) this PR fixes:

Fixes #7957

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 3, 2025
@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 8da91c0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69368f29e1fc0d0008495fce
😎 Deploy Preview https://deploy-preview-8058--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2025
@mimowo
Copy link
Contributor

mimowo commented Dec 3, 2025

cc @mbobrovskyi @IrvingMg ptal

@mszadkow mszadkow force-pushed the feat/7957-move-configureClusterProfileCache-to-pkg branch 3 times, most recently from 579efbc to 656fd55 Compare December 5, 2025 09:05
@mszadkow mszadkow force-pushed the feat/7957-move-configureClusterProfileCache-to-pkg branch from 656fd55 to 8da91c0 Compare December 8, 2025 08:41
@mimowo
Copy link
Contributor

mimowo commented Dec 8, 2025

/lgtm
/approve
/cherrypick release-0.15
Thank you 👍

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherrypick release-0.15
Thank you 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e0fcd59d70f7ab8d28c2f7d8dbaf2624fb5c78a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2ba874a into kubernetes-sigs:main Dec 8, 2025
28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Dec 8, 2025
@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #8124

In response to this:

/lgtm
/approve
/cherrypick release-0.15
Thank you 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiKueue via ClusterProfile: move configureClusterProfileCache to separate package and add unit test

5 participants