[8/11] feat: add exit/2 for sending exit signals to processes#77
Closed
unbalancedparentheses wants to merge 13 commits intolambdaclass:mainfrom
Closed
[8/11] feat: add exit/2 for sending exit signals to processes#77unbalancedparentheses wants to merge 13 commits intolambdaclass:mainfrom
unbalancedparentheses wants to merge 13 commits intolambdaclass:mainfrom
Conversation
Consolidate the two separate GenServer implementations (async/tokio and threads) into a single implementation with a Backend enum parameter. Breaking change: start() now requires a Backend argument: - Backend::Async - tokio async tasks (default) - Backend::Blocking - tokio's blocking thread pool - Backend::Thread - dedicated OS thread This provides runtime flexibility without code duplication, allowing users to mix different execution backends in the same application. - Add Backend enum to gen_server.rs - Change start() signature to accept Backend parameter - Update all examples and tests - Remove thread-based example crates
Add 10 new tests covering: - Backend enum traits (Default, Copy, Clone, Debug, PartialEq, Eq) - All three backends handle call/cast correctly - Backend::Thread isolates blocking work from async runtime - Multiple backends can run concurrently with independent state - Backend::default() works in start()
Document each backend option with: - Comparison table showing execution model, best use cases, and limitations - Code examples for each backend - Detailed "When to Use" guide with advantages and avoid-when advice - Per-variant documentation with specific use cases
Property-based tests (proptest): - Counter preserves initial state - N increments result in initial + N - Get is idempotent (multiple calls return same value) - All backends produce working GenServers - Multiple GenServers maintain independent state - Cast followed by Get reflects the cast Fuzzing (cargo-fuzz): - Add fuzz target for GenServer operations - Test random sequences of call/cast operations - Verify state consistency across all backends - Run with: cd concurrency/fuzz && cargo fuzz run fuzz_genserver_operations
… communication - Backend equivalence tests: verify all backends produce identical results - Cross-backend communication: test GenServers on different backends calling each other - Stress tests: concurrent operations, mixed call/cast - Init/teardown: verify lifecycle hooks work on all backends - State consistency: large operations, alternating operations
4 tasks
- Remove concurrency/src/threads/ directory (replaced by Backend enum) - Move files from concurrency/src/tasks/ to concurrency/src/ - Update all imports from spawned_concurrency::tasks:: to spawned_concurrency:: - Update internal crate imports accordingly - Update examples README to reflect current architecture The Backend enum (Async, Blocking, Thread) now provides all the functionality previously split between tasks and threads modules, offering a cleaner and more unified API.
- Add Pid struct with unique process identifiers (AtomicU64) - Add HasPid trait for types that have a process ID - Add ExitReason enum (Normal, Shutdown, Error, Killed) - Add MonitorRef for tracking monitors - Add SystemMessage enum (Down, Exit, Timeout) These are the foundational types for OTP-style process management.
- Add ProcessTable with global process tracking - Implement bidirectional linking (link/unlink) - Implement unidirectional monitoring (monitor/demonitor) - Add trap_exit support for catching linked process exits - Add SystemMessageSender trait for delivering DOWN/EXIT messages - Handle exit propagation to linked processes The process table is the central registry for all running processes and manages the relationships between them.
- Add global Registry for name -> Pid mapping - Implement register/unregister functions - Add whereis for name lookup - Add name_of for reverse lookup (Pid -> name) - Prevent duplicate names and multiple names per process - Add comprehensive tests with mutex for isolation Enables Erlang-style named processes for easier discovery.
Integrate the Pid, link, monitor, and registry functionality into the tasks-based GenServer: - Add Pid field to GenServerHandle for process identification - Implement HasPid trait for GenServerHandle - Add system message handling via handle_info callback - Add link/unlink methods for bidirectional process linking - Add monitor/demonitor methods for process monitoring - Add trap_exit/is_trapping_exit for exit signal handling - Add register/unregister/registered_name for process registry - Add start_linked and start_monitored convenience methods - Update lib.rs to export link, pid, process_table, registry modules - Add comprehensive Pid and registry tests
Implements Erlang/OTP-style supervision for fault-tolerant systems: Supervisor: - Manages a static set of child processes defined at start - Monitors children and restarts them according to restart strategy - Supports restart strategies: OneForOne, OneForAll, RestForOne - Child specs with: restart type, shutdown behavior, child type DynamicSupervisor: - Manages dynamically spawned children - Supports start_child/terminate_child for runtime management - Configurable max_children limit Features: - Automatic restart on child crash (permanent, temporary, transient) - Max restart intensity to prevent restart loops - Graceful shutdown with configurable timeout - Type-safe child handle abstraction - Full integration with GenServer Backend system - Comprehensive test suite (unit + integration tests)
Add support for storing and retrieving typed GenServerHandle<G> by name:
- register_handle<G>(): stores both Pid and typed handle
- lookup<G>(): returns Option<GenServerHandle<G>> for direct messaging
- has_handle(): checks if name has a typed handle stored
The existing register()/whereis() functions continue to work for
Pid-only registration. The typed registry enables name-based
messaging without keeping handle references:
registry::register_handle("counter", handle)?;
// Later, anywhere in the code:
if let Some(h) = registry::lookup::<Counter>("counter") {
h.call(Increment).await;
}
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add `process_table::exit(from, to, reason)` - the Erlang equivalent of `exit(Pid, Reason)`. The behavior follows Erlang semantics: - Kill: Unconditionally terminates the process (untrappable) - Normal to self: Process exits normally - Normal to other: Ignored (can't force another to exit "normally") - Other reasons: Kills process, or sends EXIT message if trapping Also adds `exit_self(pid, reason)` convenience function for external shutdown requests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
526cccc to
014e802
Compare
Contributor
Author
|
Reorganizing PR sequence for coherent implementation order. This content will be included in the new PR series. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
process_table::exit(from, to, reason)- the Erlang equivalent ofexit(Pid, Reason)for sending exit signals to processes.Behavior (follows Erlang semantics)
KillNormalNormalSystemMessage::ExitAPI
Test plan
Killis untrappable (even withtrap_exit)Normalto self exits normallyNormalto other process is ignoredShutdownbehaviorexit_selfconvenience functionPR Chain
PR #8 in the stacked PR chain, building on PR #7 (typed registry).
🤖 Generated with Claude Code