Skip to content

ci: make uv action tag explicit#1625

Merged
wochinge merged 1 commit intomainfrom
chore/fix-setup-uv-tag
Apr 15, 2026
Merged

ci: make uv action tag explicit#1625
wochinge merged 1 commit intomainfrom
chore/fix-setup-uv-tag

Conversation

@wochinge
Copy link
Copy Markdown
Contributor

@wochinge wochinge commented Apr 15, 2026

Changes

  • make tag explicit

Disclaimer: Experimental PR review

Greptile Summary

This PR pins astral-sh/setup-uv to an explicit commit SHA (cec208311dfd045dd5311c1add060b2062131d57 # v8.0.0) in both ci.yml and release.yml, completing the supply-chain hardening started in #1623 where other actions were similarly pinned but setup-uv was left with a floating reference.

Confidence Score: 5/5

Safe to merge — pure CI hardening with no functional changes.

The change only pins an already-used GitHub Action to its commit SHA, completing supply-chain hardening already applied to every other action in both workflow files. No logic is altered.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Pins astral-sh/setup-uv to commit SHA cec208311... (v8.0.0) across all four job steps that invoke it; no functional changes.
.github/workflows/release.yml Pins astral-sh/setup-uv to the same commit SHA as ci.yml; all other actions (actions/checkout, slackapi/slack-github-action) were already pinned.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Push / PR / workflow_dispatch] --> B[ci.yml jobs]
    A --> C[release.yml job]

    B --> D[linting]
    B --> E[type-checking]
    B --> F[unit-tests Python 3.10-3.14]
    B --> G[e2e-tests shards plus live_provider]

    D & E & F & G --> H[all-tests-passed gate]

    C --> I[release-python-sdk]
    I --> J[Build and publish to PyPI via OIDC]
    J --> K[Create GitHub Release and Slack notify]

    subgraph pinned_action [astral-sh/setup-uv pinned to SHA v8.0.0]
        D
        E
        F
        G
        I
    end
Loading

Reviews (1): Last reviewed commit: "ci: make uv action tag explicit" | Re-trigger Greptile

@wochinge wochinge enabled auto-merge (squash) April 15, 2026 08:18
@github-actions
Copy link
Copy Markdown

@claude review

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — purely a comment clarification from # v8 to # v8.0.0 with no functional change.

Extended reasoning...

Overview

This PR updates the human-readable version comment on the pinned astral-sh/setup-uv action reference in both .github/workflows/ci.yml and .github/workflows/release.yml. The SHA (cec208311dfd045dd5311c1add060b2062131d57) is unchanged; only the trailing comment changes from # v8 to # v8.0.0.

Security risks

None. The actual action version is controlled by the SHA, which is identical before and after. Making the comment more explicit (major.minor.patch) is a documentation improvement with zero security impact.

Level of scrutiny

Minimal — this is a pure comment-only change in CI config files. No logic, no permissions, no secrets handling, and no production code paths are affected.

Other factors

No bugs were found by the automated review. The change is consistent across all five occurrences in the two workflow files. This fits squarely in the "trivial clarification" category that warrants auto-approval.

@wochinge wochinge disabled auto-merge April 15, 2026 08:22
@wochinge wochinge merged commit be74cbc into main Apr 15, 2026
17 of 18 checks passed
@wochinge wochinge deleted the chore/fix-setup-uv-tag branch April 15, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant