Conversation
- Compare actual LB rule IDs in the CloudStackIsolatedNetwork watch predicate instead of only comparing the count. This ensures control plane machines are re-reconciled when rule IDs change even if the number of rules stays the same. - Use sanitized IsolatedNetworkName() in GenerateIsolatedNetwork to ensure the Kubernetes object name matches the lookup name. Previously, network names containing dots would cause a mismatch between creation and lookup. - Fix IsolatedNetwork() to return the cached CloudStackIsolatedNetwork when already populated, instead of returning an empty object. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When a load balancer rule disappears from CloudStack (e.g. due to IP disassociation or external deletion), the machine controller would fail hard on ListLoadBalancerRuleInstances and get stuck in an error loop. Now non-existent rules are skipped with a warning event, allowing the machine controller to continue processing remaining rules while the isolated network controller re-creates the missing ones. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hrak
requested review from
FarnazBGH,
jpsfalcao,
kasperhendriks and
suhasagasthya
jpsfalcao
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
predicate
when already populated, instead of returning an empty object
disassociation or external deletion), the machine controller would fail
hard on ListLoadBalancerRuleInstances and get stuck in an error loop.
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.