Add : declarations for val definitions#74
Closed
AlexKnauth wants to merge 2 commits intolexi-lambda:masterfrom
Closed
Add : declarations for val definitions#74AlexKnauth wants to merge 2 commits intolexi-lambda:masterfrom
: declarations for val definitions#74AlexKnauth wants to merge 2 commits intolexi-lambda:masterfrom
Conversation
5040e5d to
0086090
Compare
Contributor
|
FWIW this patch seems to fix recursive definitions in the REPL. Before: > (defn f : {Integer -> Integer} [[x] (f x)])
; stdin:3:37: f: no inferred type
; in: f
; [,bt for context]After: > (defn f : {Integer -> Integer} [[x] (f x)])
; (no error)This also "fixes" recursive definitions in the documentation, but it breaks existing uses of |
Owner
|
Thanks for the report; I’ve pushed a fix for the existing implementation that permits recursive definitions in the REPL. |
3575919 to
bf74547
Compare
Contributor
Author
|
Closing in favor of #86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the declaration type annotations from #73.
(: f {Integer -> Integer}) (def f (λ [x] x)) (: fact {Integer -> Integer}) (defn fact [[0] 1] [[n] {n * (fact {n - 1})}]) (: id (forall [a] {a -> a})) (defn id [[x] (: x a)]) (: rmt (forall [a b] (Monoid b) => (Either a b))) (def rmt (Right (: mempty b)))There is one issue remaining, and that is the ambiguity between the expression version and the declaration version of
:(including in the REPL and in Scribble examples). This could be solved by giving them different names.