fix: start the progress clock with the test window - #148
Open
BKPepe wants to merge 1 commit into
Open
Conversation
The progress ticker started before the transfer ramp-up while the duration timeout started after it, so the reported percentage ran ahead of the test by the ramp-up time: with the default three streams, progress reached 100 six tenths of a second before the phase ended. Start the ticker where the timeout starts, so seconds and progress describe the window they are measured against. Found while porting --json-stream to the Rust client, where the same flaw was carried over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress ticker started before the transfer ramp-up while the duration timeout started after it, so
progressran ahead of the test by the ramp-up time — with the default three streams it reached 100 six tenths of a second before the phase ended.Measured against a live server with
--duration 5 --concurrent 3:progress: 100arrivedIntroduced by #145 and found while porting
--json-streamto the Rust client, where the same flaw was carried over and fixed.