refactor: encapsulate log rotation logic#189
Draft
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Draft
refactor: encapsulate log rotation logic#189Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
This moves the `SIGHUP` signal handling from the main server loop to a dedicated background task in `ServerLogger` to make the logger responsible for its own file handle management. Co-Authored-By: Gemini 3.0 Pro
|
👋 Hi! This PR is now in draft status. |
Collaborator
|
I would rather keep the old version. I like all the handling for the different signals in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
SIGHUPsignal handling from the main server loop to a dedicated background task inServerLoggerto make the logger responsible for its own file handle management.