Conversation
|
I've assigned @wpaulino as a reviewer! |
|
The implementation confirms the PR's changes are correct. The check at This means Looking at the diff again: the PR already changes both "minimum" → "maximum" (line 1494) and "at least 100010" → "at most 99990" (line 1496). My prior review comment was a false positive — the PR already correctly fixes line 1494. No new issues found. The comment corrections are accurate and consistent with the actual implementation. |
Fix incorrect comment about cltv_expiry_delta. The cltv_expiry on the outgoing HTLC must be less than the one in the incoming HTLC.
Fix incorrect comment about cltv_expiry_delta.
The cltv_expiry on the outgoing HTLC must be less than the one in the incoming HTLC.