Add VssClient::get_version#61
Open
tankyleo wants to merge 1 commit intolightningdevkit:mainfrom
Open
Conversation
This new method gets the version of the VSS API served by the server. The method depends on the `/version` endpoint recently added to the VSS API. If this method is called against a VSS server that does not serve this endpoint, a `VssError::InternalError` will be returned. Upstream libraries should then communicate to users that the VSS server they are talking to is not supported.
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
May 6, 2026
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
One comment for now, please feel free to update and re-request review once we discussed the general approach on vss-server.
| #[cfg(genproto)] | ||
| fn generate_protos() { | ||
| download_file( | ||
| "https://raw.githubusercontent.com/lightningdevkit/vss-server/022ee5e92debb60516438af0a369966495bfe595/proto/vss.proto", |
Contributor
There was a problem hiding this comment.
While doing this on the server is fine, here I'd not want to do it until we have a better solution in place. Maybe we should go through with merging repos now that both are rust codebases, or have both depend on a shared vss-proto crate, to ensure version compat?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new method gets the version of the VSS API served by the server. The method depends on the
/versionendpoint recently added to the VSS API.If this method is called against a VSS server that does not serve this endpoint, a
VssError::InternalErrorwill be returned. Upstream libraries should then communicate to users that the VSS server they are talking to is not supported.