Update James SHA-1

[Arsnael]

Summary by CodeRabbit

• Tests

  • Added disabled test stubs marking thread-collapsing email query scenarios unsupported for no-email-query-view configurations.
  • Removed one previously-disabled test case related to attachment metadata/read-level behavior.

• Bug Fixes

  • Normalized calendar ICS attachment charset values to "US-ASCII" in test expectations.

• Chores

  • Updated submodule pointer.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Updated the james-project submodule pointer. In two JMAP integration-test classes (distributed and memory no-view variants) added four overridden test methods each, annotated with @Test, @Override, and @Disabled("JAMES-3340 Not supported for no email query view") and with empty bodies to explicitly skip thread-collapsing tests when the email query view is disabled. Removed a previously disabled override test from the Postgres JMAP EmailGetMethod test. Several JSON calendar attachment charset values were normalized from "us-ascii" to "US-ASCII".

Possibly related PRs

• [Build] Disable PostgresEmailGetMethodTest.shouldUseFastViewWithAttac… #2052 — Modifies the same PostgresEmailGetMethodTest method (direct code-level overlap).
• Update James SHA1 #2014 — Updates the james-project submodule pointer (related submodule bump).

Suggested reviewers

• quantranhong1999
• chibenwa

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update James SHA-1' accurately reflects the main change - updating a James submodule pointer to a new commit hash.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80d95bc and cfafec1.

📒 Files selected for processing (3)

• tmail-backend/integration-tests/jmap/jmap-integration-tests-common/src/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventAcceptMethodContract.scala (2 hunks)
• tmail-backend/integration-tests/jmap/jmap-integration-tests-common/src/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventMaybeMethodContract.scala (2 hunks)
• tmail-backend/integration-tests/jmap/jmap-integration-tests-common/src/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventRejectMethodContract.scala (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: Arsnael
Repo: linagora/tmail-backend PR: 2046
File: tmail-backend/jmap/extensions/src/main/scala/com/linagora/tmail/james/jmap/perfs/TMailCleverMessageParser.scala:96-96
Timestamp: 2025-12-03T04:07:30.981Z
Learning: In the tmail-backend repository, when a test is failing on the master branch and blocking builds, it's acceptable practice to include the fix in an ongoing PR even if the fix is unrelated to the PR's main objective, rather than requiring a separate PR or commit.

🔇 Additional comments (3)

tmail-backend/integration-tests/jmap/jmap-integration-tests-common/src/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventMaybeMethodContract.scala (1)

800-800: Charset normalization looks correct.

The update from "us-ascii" to "US-ASCII" aligns test expectations with the canonical IANA charset naming convention. This change is consistent with the upstream James project update.

Also applies to: 911-911

tmail-backend/integration-tests/jmap/jmap-integration-tests-common/src/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventAcceptMethodContract.scala (1)

994-994: Charset normalization is consistent with other calendar event contracts.

The "US-ASCII" update matches the changes in LinagoraCalendarEventMaybeMethodContract and aligns with the upstream James charset handling.

Also applies to: 1106-1106

tmail-backend/integration-tests/jmap/jmap-integration-tests-common/src/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventRejectMethodContract.scala (1)

800-800: Charset normalization completes the consistency across all calendar event contracts.

The "US-ASCII" update is consistent with the Accept and Maybe contracts, ensuring all calendar event test expectations align with the updated James project charset handling.

Also applies to: 913-913

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Arsnael]

broke twice in a row: https://james-jenkins.lin-saas.com/job/Tmail%20build/job/PR-2057/2/testReport/com.linagora.tmail.james/PostgresEmailQueryMethodTest/inMailboxAfterWithSortedBySentAtShouldAcceptSharedMailboxesWhenSharesExtension_GuiceJamesServer_/

Investigating...

[Arsnael]

=> apache/james-project#2879

[Arsnael]

Fingers crossed...