change: [DPS-41214] - Stream and Destination Empty Landing pages flicker on enter#13489
Open
kagora-akamai wants to merge 2 commits intolinode:developfrom
Conversation
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #1 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
||||||||||||||||||||
…pinner added before empty state
mduda-akamai
approved these changes
Mar 13, 2026
Contributor
mduda-akamai
left a comment
There was a problem hiding this comment.
✅ code review
✅ verification steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix the issue with flickering table view on the Stream and Destination Empty Landing pages when entering.
Changes 🔄
For Streams and Destinations Landing pages there are added additional loading spinners for a state before first page load.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
March 2026
How to test 🧪
Prerequisites
Run manager. Switch to MSW with no streams and destinations created.
Reproduction steps
Enter
Monitor > Logs > Streamspage.See that before empty state component is loaded the view shows table view for a split second.
Verification steps
Enter
Monitor > Logs > Streamspage.See that before empty state component is loaded the view shows spinner and then empty state component.
When entering page with existing streams, the first load shows loading spinner, then loaded page with table. On pagination the spinner is shown in place of the table, but filters and Create button are still visible.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅