-
-
Notifications
You must be signed in to change notification settings - Fork 208
REGRESSION TESTING for next Dasharo+Heads: v560tu/v540tu dasharo tag 1.0.1 / nv4x_adl 1.8.0-rc4 (ns50 partial, todo: remove changes) #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tlaurion
wants to merge
24
commits into
linuxboot:master
Choose a base branch
from
tlaurion:pre_release_dasharo_101_rc3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d36ab74
Makefile: Auto-clean board build directories when coreboot canary cha…
tlaurion 6a0d009
modules/coreboot + config/coreboot-novacustom* config/coreboot-nitrop…
tlaurion 3711051
config/coreboot-novacustom* : put in defconfig, review needed changes…
tlaurion cf91d01
config/coreboot-novacustom* : put in oldconfig, no manual change
tlaurion 3125137
config/coreboot-novacustom* : verify changes in oldconfig, first pass…
tlaurion 11c2ce6
config/coreboot-novacustom* : verify changes in oldconfig: bug in def…
tlaurion f82d7e8
config/coreboot-novacustom* : verify changes in oldconfig: bug in def…
tlaurion 61edf49
config/coreboot-novacustom* : verify changes in oldconfig: brick v560…
tlaurion 3fef91a
config/coreboot-novacustom* : verify changes in oldconfig: CMOS_ALTCE…
tlaurion 1a1b9de
coreboot-dasahro: add https://github.com/Dasharo/coreboot/pull/847 on…
tlaurion 665054b
WiP EC support
tlaurion dd634e1
Bump nix develop based docker image to v0.2.8
tlaurion 993e094
docker/DOCKER_REPRO_DIGEST .circleci/config.yml: bump to v0.2.8 docke…
tlaurion e72f3fb
Bump nix develop based docker image to v0.2.9
tlaurion baf0910
Pin docker image to digest for v0.2.9
tlaurion 96d9d15
Changes vs https://github.com/linuxboot/heads/pull/2062 to build EC o…
tlaurion b9a081f
Dasharo: put coreboot config in defconfig to show settings that neede…
tlaurion 4030da1
Dasharo: split coreboot into separate forks with shared toolchains
tlaurion c625b77
Revert: Dasharo forks build their own toolchain
tlaurion 7794cf2
Add documentation about Dasharo toolchain compatibility
tlaurion 621c8df
Fix V56 FSP header compatibility by including both paths
tlaurion cf27289
Revert V56 FSP dual-path attempt
tlaurion e4b88f8
Restore legacy coreboot-dasharo for v56 boards
tlaurion 344878c
coreboot configs : save in oldconfigs to compare with https://github.…
tlaurion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile now removes and recreates board directories every time submodules are updated. This aggressive cleaning approach could cause issues if other build artifacts or files exist in these directories that shouldn't be removed. The cleaning happens unconditionally even when it may not be necessary (e.g., when submodules haven't actually changed). Consider making this cleaning conditional or documenting why this aggressive approach is needed.