fix(google): only block generate_reply when instructions passed to immutable-context model#5715
Open
d42f wants to merge 1 commit into
Open
fix(google): only block generate_reply when instructions passed to immutable-context model#5715d42f wants to merge 1 commit into
d42f wants to merge 1 commit into
Conversation
…mutable-context model Models like gemini-3.1-flash-live-preview have mutable_chat_context=False because injecting a role=model turn via `instructions=` causes a 1007 error from the Google API. The previous guard blocked all generate_reply calls for such models, but the role=model injection only happens when `instructions` is given (line 737). Calling generate_reply() or generate_reply(user_input=...) without instructions sends only a role=user placeholder turn, which works correctly on gemini-3.1. Narrow the guard to raise only when instructions is provided. Fixes: livekit#5260
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models like gemini-3.1-flash-live-preview have mutable_chat_context=False because injecting a role=model turn via
instructions=causes a 1007 error from the Google API.The previous guard blocked all generate_reply calls for such models, but the role=model injection only happens when
instructionsis given (line 737). Calling generate_reply() or generate_reply(user_input=...) without instructions sends only a role=user placeholder turn, which works correctly on gemini-3.1.Narrow the guard to raise only when instructions is provided.
Fixes: #5260