feat(ipc): configure entrypoint shutdown timeout - #6558
Open
tmtcam-042 wants to merge 2 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
longcw
reviewed
Jul 27, 2026
| When None (default), multiprocess mode is disabled and only main process metrics are collected. | ||
| Users can also set PROMETHEUS_MULTIPROC_DIR environment variable directly before starting the worker.""" | ||
| entrypoint_shutdown_timeout: float = 15.0 | ||
| """Maximum time to wait for a job entrypoint to exit before cancelling it.""" |
Contributor
There was a problem hiding this comment.
this is the timeout only after the job shutdown, the entrypoint can run longer than 15s if the job is running. better to explain this in the docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The job process currently waits for the entrypoint for a hard-coded 15 seconds during shutdown before cancelling it. This makes that grace period configurable through
ServerOptionsandAgentServerwhile preserving the existing 15-second default.Setting
entrypoint_shutdown_timeout=0.0cancels the entrypoint immediately, allowing applications to terminate active calls without waiting for voice playout or other entrypoint work to drain. Shutdown callbacks continue to run after cancellation.Closes #6512.
Reopened because reviewer was not auto-assigned, don't think CI picks up when a PR promotes from draft to ready!
Changes
entrypoint_shutdown_timeouttoServerOptions,AgentServer, andupdate_optionsProcPoolto process and thread job executorsTesting
uv run pytest tests/test_ipc.py tests/test_worker_config.py --unit -q— 26 passedmake check— formatting, Ruff, and mypy passed across all 623 source files