Set token NotBefore Time to now #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cloud will check NotBefore timestamp to revoke tokens
cnderrauber
force-pushed
the
notbefore
branch
from
f72292c to
4061790
Compare
lukasIO
approved these changes
Dec 18, 2025
| .setIssuer(this.apiKey) | ||
| .setExpirationTime(this.ttl) | ||
| .setNotBefore(0); | ||
| .setNotBefore(new Date()); |
Contributor
There was a problem hiding this comment.
looks good!
was also curious why your previous attempt failed in the test and it turns out jose expects the unix timestamp in seconds and Date.now() returns millis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloud will check NotBefore timestamp to revoke tokens