Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| text string | ||
| highlight bool | ||
| secondary bool | ||
| noIndent bool |
There was a problem hiding this comment.
suggestion: The change makes sense to me, but I would phrase the bool the other way around: there is a double-negative feel and the zero value (false = indented) is the minority case (only SeverityInfo gets indented). Since Go's default value for bool is false, it's cleaner to flip to indent bool so the default means "no indent".
carole-lavillonniere
left a comment
There was a problem hiding this comment.
Just one suggestion to make the code simpler and easier to read, otherwise it looks good!
|
I'm not sure why we had that indent in the first place 🤔 |
Do we want to keep it for the Info severity @gtsiolis? |
See DES-152 for more context.
** Ignore the missing information in the header, will fix in a follow up PR, logout does not need the header. 👾