Add --config flag to override config file location#80
Open
carole-lavillonniere wants to merge 1 commit intocarole/drg-550from
Open
Add --config flag to override config file location#80carole-lavillonniere wants to merge 1 commit intocarole/drg-550from
carole-lavillonniere wants to merge 1 commit intocarole/drg-550from
Conversation
test/integration/license_test.go
Outdated
| cmd.Env = env.With(env.APIEndpoint, mockServer.URL).With(env.AuthToken, "test-token-for-license-validation") | ||
| output, err := cmd.CombinedOutput() | ||
|
|
||
| _, stderr, err := runLstk(t, "", env.With(env.APIEndpoint, mockServer.URL).With(env.AuthToken, "test-token-for-license-validation"), "start") |
Collaborator
Author
There was a problem hiding this comment.
We now use runLstk in each integration test. Previously it was only used in config_test.go
carole-lavillonniere
force-pushed
the
carole/drg-551-config-flag
branch
3 times, most recently
from
6687d22 to
60396ea
Compare
carole-lavillonniere
force-pushed
the
carole/drg-551-config-flag
branch
from
60396ea to
1754153
Compare
carole-lavillonniere
requested review from
anisaoshafi and
silv-io
as code owners
silv-io
approved these changes
Mar 5, 2026
Member
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM! I wonder if we'll need that for the tests launched in the pty as well?
Collaborator
Author
Yes could be at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--configflag, allowing users to specify a custom config file path (e.g.lstk --config /path/to/config.toml start)