fix: prevent silent errors from overwriting TUI error display

[carole-lavillonniere]

Fix regression and bring back change from #72

Before	After

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3f7ce383-082a-4122-ac4a-3948fecedc90

📥 Commits

Reviewing files that changed from the base of the PR and between a7ee41a and dd69a71.

📒 Files selected for processing (2)

• internal/ui/app.go
• internal/ui/app_test.go

---

📝 Walkthrough

Walkthrough

The pull request makes error display conditional on whether an error is marked as silent. Previously, all errors triggered the display; now only non-silent errors do. Two tests verify this behavior: silent errors don't overwrite existing displays, while non-silent errors populate and show them.

Changes

Cohort / File(s)	Summary
Error Display Logic internal/ui/app.go	Modified error handling in RunErrMsg to conditionally show errors only when they are non-silent via output.IsSilent(msg.err) check.
Test Coverage internal/ui/app_test.go	Added two test cases validating silent error preservation and non-silent error display behavior, plus fmt import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Display error with TUI and suppress duplicate error #81: Modifies the same error-display logic in internal/ui/app.go with related conditional error handling for silent errors.

Suggested reviewers

• silv-io

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: preventing silent errors from overwriting the TUI error display, which matches the code modification in app.go that adds conditional logic to only show non-silent errors.
Description check	✅ Passed	The description references a regression fix and provides visual context showing the improvement in error messaging, directly relating to the changeset that prevents silent errors from overwriting error display.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/silent-error-overwrite

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gtsiolis]

UX works as expected, thanks for fixing this, @carole-lavillonniere! 🏀

[silv-io]

Great catch, thank you for the fix!