fix(cli): support keyTo option in belongsTo relation generator#11648
Open
Abubakar-K-Back wants to merge 2 commits into
Open
fix(cli): support keyTo option in belongsTo relation generator#11648Abubakar-K-Back wants to merge 2 commits into
Abubakar-K-Back wants to merge 2 commits into
Conversation
Abubakar-K-Back
force-pushed
the
fix/belongs-to-keyto-support
branch
from
e0f623e to
5fc5eea
Compare
Contributor
|
Hi, @Abubakar-K-Back. Can you please add the tests for your changes? And you need to fix the commit message. |
The belongsTo relation generator ignores the keyTo option when provided. This fix passes keyTo through to the model decorator, overrides fktype using the target field's actual type, and reflects the keyTo in the controller OpenAPI description. Fixes loopbackio#11647 Signed-off-by: Abubakar Awan <abkawan6@gmail.com>
Abubakar-K-Back
force-pushed
the
fix/belongs-to-keyto-support
branch
from
5fc5eea to
cb196ee
Compare
Abubakar-K-Back
changed the title
Adds integration tests verifying that the keyTo option is passed through the --config flag and reflected in the generated model decorator and controller description. Also fixes the relation generator to propagate keyTo from CLI options to artifactInfo so --config usage works correctly. Signed-off-by: Abubakar Awan <abkawan6@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description section:
Fixes #11647
When generating a
belongsTorelation with a customkeyTofield, the CLI generator was silently ignoring thekeyTooption it was not included in the generated@belongsTodecorator, and the FK type was always resolved from the destination model's primary key type instead of the actualkeyTofield type.Changes:
keyTotogetBelongsTo()and include it in the decorator argumentsfktypefrom the actualkeyTofield type usinggetModelPropertyType()keyTointoartifactInfoingenerateControllers()for controller template accesskeyTofield in the OpenAPI description