Ported GradientFilter from Cxx to Python#133
Open
FlorianFritz wants to merge 4 commits intolorensen:masterfrom
Open
Ported GradientFilter from Cxx to Python#133FlorianFritz wants to merge 4 commits intolorensen:masterfrom
FlorianFritz wants to merge 4 commits intolorensen:masterfrom
Conversation
ajpmaclean
reviewed
Feb 26, 2018
| iren.SetRenderWindow(renwin) | ||
| iren.Initialize() | ||
| iren.Start() | ||
| return 1 |
Collaborator
There was a problem hiding this comment.
This return statement is not needed.
Collaborator
|
Looks good. Here are some extra things you will need to do:
Steps 1, 2 ensure that the code appears on the web page in the correct section with a nice picture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain port from Cxx to Python