DM-55223: Add PPDB query interface#65
Merged
Merged
Conversation
JeremyMcCormick
approved these changes
Jun 12, 2026
There was a problem hiding this comment.
As a first version of tools for accessing the PPDB for AP analysis, this looks good. I was able to run the corresponding PR with the Python notebooks successfully after working through some minor configuration issues.
I would suggest in the future to add some tests that do not use a mock TAP service and would be enabled if an RSP token is available in the environment. (These would not be run in Jenkins but it could be possible to eventually enable them in GitHub CI or to run them locally.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.